Repository navigation
Check plugin.yml with the parser a server uses - #41
Merged
Merged
Conversation
PluginManifestTest read the manifest as plain YAML, so a name the server would rewrite or reject and a wrong api-version all passed. Load it through PluginDescriptionFile and assert the name and api-version. The permission default stays on plain YAML because building a Permission needs a running server. Closes #39 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric, scored on
Findings left open, none blocking:
The checks do not start a server, so plugin loading is still verified by hand. No DPC testing convention was checked, because This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
added a commit
that referenced
this pull request
Nov 12, 2026
Five merges since the 1.0.0 release changed what users or contributors see without a CHANGELOG entry: the README image (#29), the CONTRIBUTING build step (#28), the dev prerelease wording (#33), the CONFIG.md permission text (#34) and the PluginDescriptionFile manifest tests (#41). The Unreleased section even logged a fix to the image's caption without ever logging the image. Add the missing entries. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginManifestTestexists to notice a manifest problem before a server does, but it readplugin.ymlas plain YAML and never reached the parser a server uses.PluginDescriptionFile, so anything that parser rejects fails the suite.api-versionare now asserted. Both are stated in the docs, and the name is the prefix of/flycommand:fly.Tests and docs only.
Main.java,plugin.ymland the workflows are untouched.Closes #39
Limitation
The permission default is still read as plain YAML.
PluginDescriptionFile.getPermissions()buildsPermissionobjects, which need a running server (NullPointerExceptiononBukkit.getServer()). The parser does load the whole file, but thepermissionsblock's content is not checked by it here.Skipped
pom.xmlis still at1.0.1, andgit ls-remote --tagsshows onlyv1.0.0anddev.Validation
mvn -B clean package:Tests run: 10, Failures: 0, Errors: 0, Skipped: 0,BUILD SUCCESS, on the restoredplugin.yml(git statusshows it unchanged).Each mutation below was applied to
plugin.ymltemporarily and reverted:plugin.ymlmutationname: Fly Commandapi-version: 1.12also applied)nameIsTheOneTheDocsUsefailed:expected: <FlyCommand> but was: <Fly_Command>api-version: 1.12apiVersionIsTheOneTheDocsStatefailed:expected: <1.13> but was: <1.12>name: Fly!CommandInvalidDescriptionException: name 'Fly!Command' contains invalid characters.The DPC testing conventions page was not read:
gh apineeds approval in this headless run. No on-server recipe applies, because no plugin behaviour changes.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson